Repository navigation
Restart mechanism with a wall-time budget - #92
Merged
romainljsimon merged 3 commits intoOct 8, 2026
Merged
Conversation
Add the engine primitives so a simulation can run longer than an HPC
walltime by stopping cleanly and resuming later:
- run!(; wall_time): stop on a wall-clock budget, return :completed or
:need_restart; short-circuit guard for schedulers that end before steps
- Simulation gains a t_start field/kwarg: resume at t_start and skip
already-completed schedule points
- Store{Callbacks,Trajectories,Acceptance} open output files in append
mode on restart (t_start > 0); file opening moved from constructors into
initialise; store_first no longer re-fires on restart; summary.log appended
Tests: test/restart_test.jl (5 testsets, 20 assertions), wired into suite.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
romainljsimon
self-requested a review
September 24, 2026 21:04
V-Francois
requested changes
Sep 25, 2026
V-Francois
left a comment
There was a problem hiding this comment.
I think edge cases could be handled a bit better, without spreading the logic over multiple parts of the code.
Happy to discuss this if someone disagrees.
romainljsimon
requested changes
Sep 27, 2026
romainljsimon
left a comment
Member
There was a problem hiding this comment.
Thanks for the nice PR @cyfraysse !!
I have one comment on defining the default value of status as :completed, else I find this PR great.
…ases clarification
romainljsimon
approved these changes
Oct 7, 2026
romainljsimon
left a comment
Member
There was a problem hiding this comment.
Thanks :) I added a catch for when the simulation fails
|
Can you bump the version (the patch I guess since it's still in 0), so we can merge and release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the engine primitives so a simulation can run longer than an HPC walltime by stopping cleanly and resuming later:
Note : Engine in order to use it with ParticlesMC (see PR of the same name in ParticlesMC repo).